Doc String -- Dictionary key of Gradient Argument -- update heat_map.py -- folium.plugins#2096
Closed
krishna0125 wants to merge 1 commit intopython-visualization:mainfrom
Closed
Doc String -- Dictionary key of Gradient Argument -- update heat_map.py -- folium.plugins#2096krishna0125 wants to merge 1 commit intopython-visualization:mainfrom
krishna0125 wants to merge 1 commit intopython-visualization:mainfrom
Conversation
In the docstring, the gradient dictionary keys are mentioned as integers, but I believe the backend code expects them to be strings. So, I changed the docstring to reflect this, from integer values (e.g., .8) to string values (e.g., ".8").
Collaborator
|
There is an error in the automated tests. At first glance it does not appear to be related to your change. Will have a look at it over the weekend. |
Author
|
@hansthen , were you able to look into the error during the weekend. Please let me know if you need help on this. |
Collaborator
|
I had a look at your PR, but there seems to be an underlying issue. We did a refactor that broke passing dicts with non-string keys to Leaflet. |
Collaborator
|
Your change seems to implement a workaround for the underlying issue. Since the underlying issue is easy to fix, it seems better to me to go ahead with the fix here: #2100. Thank you for providing a PR. Even though we will go another direction, without your PR we would not have found the underlying issue. You contribution is appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docstring, the gradient dictionary keys are mentioned as float, but I believe the backend code expects them to be strings. So, I changed the docstring to reflect this, from float values (e.g., .8) to string values (e.g., ".8").